Added commands to install&update devon4node and cicdgen#280
Added commands to install&update devon4node and cicdgen#280hohwille merged 9 commits intodevonfw:masterfrom
Conversation
|
@dario-rodriguez thanks for this PR. This is very valuable stuff. 👍 I have not tested your changes but as cicdgen is already out in the wild, I assume this feature would be ready to go and besides someone else testing it, I would consider this as accepted already. Does that make sense to you? |
|
Hello, I created this PR because Santos wants it in the next release. |
|
Anyway, for me doesn't makes sense create a command inside the ide in order to execute devon4node commands. For me is ok if you install it globally when you install npm. |
|
While we have access to Does it make sense? |
|
I think it is complex to clarify this while chatting in this issue. I was asking for workshops and discussions about shaping the devon-ide CLI and its philosophy. So far nobody ever gave feedback to any of my questions regarding the CLI design so I made it up on my own. |
|
So Further |
|
Hello, as you can see in the npm page, this a beta version so the code is not merge yet. You can find it in the PR is already created: devonfw/devon4ts#17 |
|
Hi @dario-rodriguez, what is quite interesting is, that you are able to generate also devon4j archetype with your cli. Is that right? What is the difference to the command devon4j provided into the devon ide, which generates a new devon4j project? In addition, I would suggest to include the commands of the devon4ng cli into the respective commands already available. For example as @hohwille said, there is already the command |
|
Hello @maybeec ,
Another solution could be, instead of creating a new command for cicdgen, add it in the current commands (java, ng, node) like: What do you think @hohwille ? In your opinion which is the best approach? |
|
This really sounds good. I like the idea of the sub "cicd" command. |
…-rodriguez/ide into feature/devon4node-cicdgen
|
I updated this PR with the latest requirements. |
hohwille
left a comment
There was a problem hiding this comment.
@dario-rodriguez Awesome. Looking very good now 👍
IMHO the PR could already be merged. However, I added some review comments and ask you to have a look and see if you can do some improvements. If we do not have any time left, we could merge as is and rework later. However, I think it should be easy to rework the last improvements.
Thank you so much for your valuable contribution.
|
Hello @hohwille , This PR is updated in order to satisfy your comments. |
hohwille
left a comment
There was a problem hiding this comment.
@dario-rodriguez very well done. Awesome now. Thank you so much 👍
This PR includes two new commands:
The purpose of those commands is to install&update&execute those devonfw tools.